[6.x] Ability to override set user's password on password reset
#30218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR solves the issue of hashing the password twice when using a mutator like `setPasswordAttribute` in User model
jasonvarga
added a commit
to statamic/cms
that referenced
this pull request
Dec 2, 2020
Closes #2795 Looks like we were overriding the entire resetPassword method because it was before a setUserPassword method was extracted in laravel/framework#30218 Seems like that PR was created for almost the same reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue of hashing the password twice when using a mutator like
setPasswordAttributein User model.Also, avoiding to override the whole method in
Illuminate\Foundation\Auth\ResetsPasswordsto solve this issue.Related: #11012