New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix RedirectController parameters pop #30783

Merged

taylorotwell merged 1 commit into laravel:6.x from clementmas:6.x

Dec 9, 2019

Contributor

clementmas commented Dec 7, 2019

Fixes #30639

Using pop() to access parameters is not precise and can leads to bugs like the one described in the issue. So using get() is a safer approach.


          replace collection pop() with get() accessor

d146311

clementmas changed the title ~~Fixes RedirectController parameters pop~~ Fix RedirectController parameters pop

GrahamCampbell changed the title ~~Fix RedirectController parameters pop~~ [6.x] Fix RedirectController parameters pop

taylorotwell merged commit ff807cc into laravel:6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet