Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix Builder::withCount() binding error when a scope is added into related model with binding in a sub-select #30869

Merged
merged 2 commits into from
Dec 18, 2019
Merged

[6.x] Fix Builder::withCount() binding error when a scope is added into related model with binding in a sub-select #30869

merged 2 commits into from
Dec 18, 2019

Commits on Dec 18, 2019

  1. add failing test case of withCount with 'select' with binding in cons… 

    …traint
    @miklcct
    miklcct committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    e951bbf View commit details
    Browse the repository at this point in the history

  2. remove 'select' bindings in withCount to prevent binding error if the… 

    … relation is scoped to add a sub-select with binding
    @miklcct
    miklcct committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    140114f View commit details
    Browse the repository at this point in the history