Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Restore phpunit 7 support #31113

Merged
merged 6 commits into from
Jan 17, 2020
Merged

[6.x] Restore phpunit 7 support #31113

merged 6 commits into from
Jan 17, 2020

Conversation

GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Jan 13, 2020

Closes #31101.

@GrahamCampbell GrahamCampbell changed the title [6.x] Restore phpunit 7 support [WIP] [6.x] Restore phpunit 7 support Jan 13, 2020
@spawnia
Copy link
Contributor

spawnia commented Jan 16, 2020

Thank you. I really dislike the direction that PHPUnit has been going in lately with locking down classes/methods to be impossible to extend.

@GrahamCampbell
Copy link
Member Author

PHPUnit 7 support will be removed in Laravel 7, however.

  1. Laravel 5.8 supports PHPUnit 7 and 8.
  2. Laravel 6 supports PHPUnit 7, 8 and 9 (we are treating it as a bug that support for PHPUnit 7 is currently not present in Laravel 6, and this PR will restore it)
  3. Laravel 7 will support only PHPUnit 8 and 9, when it is released in a few weeks.

The reason for saying Laravel 6 will support PHPUnit 9, even though it's not out yet, is because Laravel 6 is an LTS release, and so needs to work on PHP 8.0 and 8.1 when they come out. There's a good chance PHPUnit 7 or 8 won't work properly on PHP 8, but PHPUnit 9 will likely get any fixes backported to it from PHPUnit 10.

@driesvints
Copy link
Member

@GrahamCampbell any chance we can get the tests fixed so we can get this merged? I think there's just a copy/paste gone wrong. The Assert class seems to be placed twice inside the same if statement.

@lukasjuhas
Copy link

Thank you for this!

@GrahamCampbell
Copy link
Member Author

Added that missing line. Looks like the tests were broken on PHPUnit 7, since the exception assertion stuff isn't present.

@GrahamCampbell GrahamCampbell changed the title [WIP] [6.x] Restore phpunit 7 support [6.x] Restore phpunit 7 support Jan 16, 2020
@taylorotwell taylorotwell merged commit 5eff676 into 6.x Jan 17, 2020
@GrahamCampbell GrahamCampbell deleted the phpunit-7 branch January 17, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declaration of ArraySubset::evaluate incompatible with PHPUnit 7.5
5 participants