-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.x] Restore phpunit 7 support #31113
Conversation
Thank you. I really dislike the direction that PHPUnit has been going in lately with locking down classes/methods to be impossible to extend. |
PHPUnit 7 support will be removed in Laravel 7, however.
The reason for saying Laravel 6 will support PHPUnit 9, even though it's not out yet, is because Laravel 6 is an LTS release, and so needs to work on PHP 8.0 and 8.1 when they come out. There's a good chance PHPUnit 7 or 8 won't work properly on PHP 8, but PHPUnit 9 will likely get any fixes backported to it from PHPUnit 10. |
@GrahamCampbell any chance we can get the tests fixed so we can get this merged? I think there's just a copy/paste gone wrong. The Assert class seems to be placed twice inside the same if statement. |
Thank you for this! |
Added that missing line. Looks like the tests were broken on PHPUnit 7, since the exception assertion stuff isn't present. |
8fea834
to
9c934d4
Compare
Closes #31101.