Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix loading deferred providers for binding interfaces and implementations #31629

Merged
merged 6 commits into from
Feb 28, 2020
Merged

[6.x] Fix loading deferred providers for binding interfaces and implementations #31629

merged 6 commits into from
Feb 28, 2020

Commits on Feb 27, 2020

  1. Add test that failes to load deffered provider of implementation whil… 

    …e accessing class through interface
    @lprzybylek
    lprzybylek committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    c0cfc13 View commit details
    Browse the repository at this point in the history

  2. Call make instead of resolve to load deffered providers 

    This commit brings back behaviour from Laravel 5.7 when you could use deferred provides to bind an interface to implementation even when implementation had its own deferred provider. Changing `resolve` method to `make` results in calling `Illuminate\Foundation\Application::make` method which loads deferred providers. Calling `resolve` method calls `Illuminate\Container\Container::resolve` which does not load deferred providers.
    @lprzybylek
    lprzybylek committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    8943aad View commit details
    Browse the repository at this point in the history

  3. Revert "Call make instead of resolve to load deffered providers" 

    This reverts commit 8943aad.
    @lprzybylek
    lprzybylek committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    00bc2c0 View commit details
    Browse the repository at this point in the history

  4. Create resolve method which loads deferred providers if needed 

    It allows resolving object by interface when using separate deferred providers for interface and implementation.
    @lprzybylek
    lprzybylek committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    746f2e9 View commit details
    Browse the repository at this point in the history

  5. Fix styling for phpdoc

    @lprzybylek
    lprzybylek committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    86a64fb View commit details
    Browse the repository at this point in the history

  6. Fix phpdoc

    @lprzybylek
    lprzybylek committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    1b6b99a View commit details
    Browse the repository at this point in the history