[8.x] Fix exit code of down/up commands when already down/up #32200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will return exit code 0 instead of boolean true. The boolean will be cast to an int resulting in exit code 1, but if the application is already down/up exit code 0 would be desirable.
Targeted to 8.x as discussed in #32199.
Change
Context
Our deploymenttool (DeployHQ) performs
php artisan down
before uploading the changes, but stops if this fails. If the deployment fails later in the process - composer install or a migration might fail - our tool stops and the application is still in maintenance mode. If we fix the error and restart the deploymentphp artisan down
now returns an exit code other than 0 and our tool thinks it failed and stops the deployment. This results in a 'locked' state where we have to manually bring the application back up before we can start a new deployment.