Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix bad method call exception on LazyCollection dd() & dump() methods #33927

Closed
wants to merge 4 commits into from
Closed

Conversation

stephenjude
Copy link

This PR fixes bad method call exception on LazyCollection dd() & dump() methods.

Fixes #33926

src/Illuminate/Support/LazyCollection.php Outdated Show resolved Hide resolved
src/Illuminate/Support/LazyCollection.php Outdated Show resolved Hide resolved
@taylorotwell
Copy link
Member

Ping @JosephSilber

@JosephSilber
Copy link
Member

JosephSilber commented Aug 20, 2020

push is a mutating method. We have no mutating methods on the lazy collection.

I submitted a fix for the dump method here: #33944.

@stephenjude
Copy link
Author

Okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dd() on Lazy collection returns bad method call exception: push does not exist.
5 participants