Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add crossJoinSub method to the query builder #34400

Merged

Conversation

maikelvanmaurik
Copy link
Contributor

The builder contains a leftJoinSub and rightJoinSub but is missing a crossJoinSub. I needed this as I was building a query similar to the one I added to the test. I assume I'm not the only one who will find this method useful.

@driesvints driesvints changed the title Add crossJoinSub method to the query builder [8.x] Add crossJoinSub method to the query builder Sep 18, 2020
@driesvints
Copy link
Member

Ping @staudenmeir

@taylorotwell taylorotwell merged commit 0151e10 into laravel:8.x Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants