[8.x] Guard against invalid guard in make:policy #34792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When using artisan to make a policy, and an invalid guard is provided to the command, as is the case in this example,
php artisan make:policy --model=Project --guard=foo ProjectPolicy
the generated code for the policy is invalid.The
$dummyUser
used in the replaceModel method is set to null, which then fails to generate correctly.Sample code generated with bad guard.
Solution:
The solution proposed here is to check for the existence of the guard, and throw an exception if it is null.