[8.x] Add when() and unless() methods to MailMessage #34814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
when()
andunless()
methods to theMailMessage
class. The implementation is identical to theIlluminate\Database\Concerns\BuildsQueries::when()
andIlluminate\Database\Concerns\BuildsQueries::unless()
equivalents.An example use case:
During implementation I noticed I could just copy the methods from
BuildsQueries
trait without any changes, similar with the tests. I think this may be a good time to refactor these methods out of theBuildsQueries
trait to something more generic and utilize them in other places without code duplication. I cannot think of any good place for them, though. What do you think?Removing them from
BuildsQueries
and putting them somewhere else could however break backwards compatibility if someone uses this trait directly but that would need further testing to confirm.