[8.x] Make assertSee, assertSeeText, assertDontSee and assertDontSeeText accept an array #34982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
assertSee
,assertSeeText
,assertDontSee
andassertDontSeeText
to work with arrays. Unlike the-InOrder
methods, these won't check the order.Before:
After:
Benefits
It's mostly a code style change. In projects where the frontend can change unexpectedly, this will avoid errors because of the order while keeping things compact
Notes
htmlspecialchars() expects parameter 1 to be string, _______ given
but I'm not too sure about it.assertStringContainsString
inside a foreach because I don't know if there's a better PHPUnit assertion for this case. This makes it soOK (1 test, 3 assertions)
shows several assertions (one for each item in the array) which never bothered me. I'm guessing copying the strategy used inIlluminate\Testing\Constraints\SeeInOrder
could deal with this?