Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Ignore max attempts if retryUntil is set #35214

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

themsaid
Copy link
Member

Currently if a job fails due to an exception and retryUntil time has not passed yet, the worker will check for maxAttempts. However, if the job was released and retryUntil has not passed yet, the worker will not check for maxAttempts.

The PR unifies the behaviour. So with this PR, if a retryUntil is set the worker is going to ignore maxAttempts completely.

Solves #35199

@taylorotwell
Copy link
Member

It looks like maxExceptions will still be respected? If that is the case I don't have a big problem with this change.

@themsaid
Copy link
Member Author

No behaviour change around maxExceptions with this PR.

@taylorotwell taylorotwell merged commit 56f79e2 into laravel:8.x Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants