Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Ensure DBAL custom type doesn't exists #35704

Merged
merged 1 commit into from
Dec 23, 2020
Merged

[8.x] Ensure DBAL custom type doesn't exists #35704

merged 1 commit into from
Dec 23, 2020

Conversation

shaffe-fr
Copy link
Contributor

@shaffe-fr shaffe-fr commented Dec 23, 2020

Hi,

When a type is registered twice, an exception is thrown.
As the DBAL types registry is a static singleton, the same instance is used when running tests.

Does this need a test?
Should we overwrite a type that is already registered?

Thanks

As the DBAL type registry is a static singleton, when running multiple tests, type may be already registered.
@taylorotwell taylorotwell merged commit 843f8bb into laravel:8.x Dec 23, 2020
@shaffe-fr shaffe-fr deleted the patch-1 branch December 23, 2020 14:32
@GrahamCampbell GrahamCampbell changed the title Ensure DBAL custom type doesn't exists [8.x] Ensure DBAL custom type doesn't exists Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants