Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix worker --delay option #35991

Merged
merged 1 commit into from
Jan 22, 2021
Merged

[8.x] Fix worker --delay option #35991

merged 1 commit into from
Jan 22, 2021

Conversation

themsaid
Copy link
Member

The --delay option was replaced with --backoff. However, the worker still accepts the --delay option to support old daemons running on servers.

The problem is that since we introduced --backoff, --delay stopped working because $this->hasOption('backoff') always returns true.

In this PR we fix that by using the highest value provided from the options. Since they both default to zero, the highest value will be the option provided.

@taylorotwell taylorotwell merged commit 6b01aea into laravel:8.x Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants