Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Typecast page number as integer #36055

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

driesvints
Copy link
Member

Atm when a custom page resolver is defined (like Livewire does) which doesn't always returns integers, a DB query for pagination could blow up (as I've experienced in Laravel.io). Since the return type hints that only an integer can be returned here it should be safe to typecast this.

See livewire/livewire#2409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants