Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Make use of specified ownerKey in MorphTo::associate() (attempt #2) #36303

Merged
merged 2 commits into from
Feb 17, 2021
Merged

[8.x] Make use of specified ownerKey in MorphTo::associate() (attempt #2) #36303

merged 2 commits into from
Feb 17, 2021

Conversation

garbetjie
Copy link
Contributor

Another attempt at creating a PR for #36296, this time with the tests working.

I'm not that experienced with writing tests, so forgive me if my understanding here is incorrect; but I'm not 100% convinced the tests cover the change made. Should it not be split into two tests - one like what is contained in this PR, and another that also checks for the execution of getKeyName()? I'm not sure how granular the tests should go.

@taylorotwell taylorotwell merged commit 16ab323 into laravel:8.x Feb 17, 2021
@axlon
Copy link
Contributor

axlon commented Mar 18, 2021

This PR broke my project, will be creating an issue with details soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants