[8.x] Deprecate dispatch_now & dispatchNow

[driesvints]

Deprecate dispatch_now helper and dispatchNow method on the Dispatchable trait so we can remove it in a future Laravel version. See #36743 (comment)

[SjorsO]

Is the dispatchNow() method on the Dispatchable trait also deprecated?

[driesvints]

@SjorsO was doubting that but yeah we can do that as well. Pushed a commit.

[kawax]

dispatchNow and dispatchSync work a little differently.

class FooJob implements ShouldQueue
{
    public function handle()
    {
        return 'bar';
    }
}

$bar = FooJob::dispatchSync();
//?

$bar = FooJob::dispatchNow();
//bar

If ShouldQueue is not implemented

class FooJob
{
    public function handle()
    {
        return 'bar';
    }
}

$bar = FooJob::dispatchSync();
//bar

$bar = FooJob::dispatchNow();
//bar

I'm using dispatchNow to get the return value, so I still need it.

[driesvints]

@kawax please see the link in my first comment.

[renoirtech]

Guys, after a shift from 7 to 8 we've noticed that dispatchSync does not work just like dispatchNow, was this the purpose or we can send a PR?

We've used to get returns from synchronous tasks and dispatchSync just return 0 (false) values.

[driesvints]

@renoirtech see #37023