[8.x] Accept any instance of Rule and not just Password
#37407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be useful if there a requirement to use custom Password implementation such as `Laravel\Fortify\Rules\Password` etc.
GrahamCampbell
requested changes
May 19, 2021
| @@ -123,7 +123,7 @@ public static function default() | |||
| { | |||
| $password = value(static::$defaultCallback); | |||
|
|
|||
| return $password instanceof static ? $password : static::min(8); | |||
| return $password instanceof Rule ? $password : static::min(8); | |||
There was a problem hiding this comment.
Surely self is the correct thing to put here?
There was a problem hiding this comment.
Laravel\Fortify\Rules\Password just implements Illuminate\Contracts\Validation\Rule. At current state you cannot set defaults by returning Laravel\Fortify\Rules\Password.
There was a problem hiding this comment.
Without this changes:
use Laravel\Fortify\Rules\Password as FortifyPassword;
use Illuminate\Validation\Rules\Password;
Password::defaults(function () {
return (new FortifyPassword())->length(10);
});
Password::defaults() // return Illuminate\Validation\Rules\Password with min 8 instead of 10.There was a problem hiding this comment.
Ok. I think we probs wanna add a test covering this, to check this doesn't break in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be useful if there a requirement to use custom Password implementation such as
Laravel\Fortify\Rules\Passwordetc.