Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Correct minimum Predis version #37554

Merged
merged 1 commit into from
Jun 1, 2021
Merged

[8.x] Correct minimum Predis version #37554

merged 1 commit into from
Jun 1, 2021

Conversation

apollopy
Copy link
Contributor

@apollopy apollopy commented Jun 1, 2021

Predis did not support php7.2 until 1.1.2：
https://github.com/predis/predis/releases/tag/v1.1.2

@driesvints driesvints changed the title [8.x]Correct minimum Predis version [8.x] Correct minimum Predis version Jun 1, 2021
@GrahamCampbell
Copy link
Member

This needs changing in all composer.json files including the recommends blocks.

@apollopy
Copy link
Contributor Author

apollopy commented Jun 1, 2021 •
edited
Loading

Everything else seems to be right

https://github.com/laravel/framework/blob/8.x/composer.json#L145
https://github.com/laravel/framework/blob/8.x/src/Illuminate/Redis/composer.json#L30

@taylorotwell taylorotwell merged commit cacc78b into laravel:8.x Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apollopy @GrahamCampbell @taylorotwell