Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fixed dns_get_record loose check of A records for active_url rule #37675

Merged
merged 1 commit into from
Jun 13, 2021
Merged

Conversation

0xcrypto
Copy link
Contributor

Fixed dns_get_record loose check of A records for active_url rule.

Tested on Laravel v8.46.0, PHP v8.0.7.

This patch is related to security issue I reported at https://huntr.dev/bounties/2-laravel/framework/.

Fixed dns_get_record loose check of A records for active_url rule. 

Tested on Laravel v8.46.0, PHP v8.0.7.

This patch is related to security issue I reported at https://huntr.dev/bounties/2-laravel/framework/.
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

@0xcrypto
Copy link
Contributor Author

No tests?

I have manually tested it. If you are a maintainer, can you please see the report I submitted and validate it? It will help me earn a bounty from huntr.dev. Thank you.

@taylorotwell
Copy link
Member

Can you explain why appending a . is the correct fix?

@it-can
Copy link
Contributor

it-can commented Jun 13, 2021

Can you explain why appending a . is the correct fix?

https://stackoverflow.com/questions/44494878/phps-dns-get-record-returning-subdomain-record-instead-of-domain-record/44787603#44787603

@taylorotwell taylorotwell merged commit c50087d into laravel:6.x Jun 13, 2021
@0xcrypto
Copy link
Contributor Author

Thanks @taylorotwell, can you please also validate the patch on huntr.dev (https://huntr.dev/bounties/2-laravel/framework/). I have another security report https://huntr.dev/bounties/3-laravel/framework/ but I am unsure of the fix for this one. If anyone wants to fix it, there is a bounty reward of 75$ by huntr.dev on this one.

chu121su12 pushed a commit to chu121su12/framework that referenced this pull request Jun 14, 2021
Fixed dns_get_record loose check of A records for active_url rule. 

Tested on Laravel v8.46.0, PHP v8.0.7.

This patch is related to security issue I reported at https://huntr.dev/bounties/2-laravel/framework/.
@GrahamCampbell GrahamCampbell changed the title Fixed dns_get_record loose check of A records for active_url rule [6.x] Fixed dns_get_record loose check of A records for active_url rule Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants