Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Change the order of the bindings for a Sql Server query with a offset and a subquery order by #37728

Merged
merged 6 commits into from
Jun 21, 2021
Merged

[8.x] Change the order of the bindings for a Sql Server query with a offset and a subquery order by #37728

merged 6 commits into from
Jun 21, 2021

Commits on Jun 18, 2021

  1. Change the order of the bindings for a sql server query with a limit 

    As SQL Server moves the OrderBy part to be part of the "select" part of
the query, we need to move the Order bindings to be in the right place.
    @thijsvdanker
    thijsvdanker committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    7baf247 View commit details
    Browse the repository at this point in the history

  2. Fix style issue

    @thijsvdanker
    thijsvdanker committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    2bcdbb0 View commit details
    Browse the repository at this point in the history

  3. Use regular function for php 7.3 compatibility

    @thijsvdanker
    thijsvdanker committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    27ddf7d View commit details
    Browse the repository at this point in the history

  4. Only move order bindings when the order contains a subquery

    @thijsvdanker
    thijsvdanker committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    94c8b3e View commit details
    Browse the repository at this point in the history

  5. Fix codestyle

    @thijsvdanker
    thijsvdanker committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    3ec1070 View commit details
    Browse the repository at this point in the history

  6. Fix 7.3 regression with short closure

    @thijsvdanker
    thijsvdanker committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    416339e View commit details
    Browse the repository at this point in the history