Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix passing cursor to pagination methods #37996

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

driesvints
Copy link
Member

At the moment the docblocks for these methods indicate that you can pass a string or null. However, this is incorrect as the current behavior is to pass either an instance of Illuminate\Pagination\Cursor or null. This PR implements support for all three.

@taylorotwell taylorotwell merged commit e84a2f6 into 8.x Jul 13, 2021
@taylorotwell taylorotwell deleted the fix-passing-cursor branch July 13, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants