Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Update the ParallelRunner to allow for a custom Runner to be resolved #38374

Merged
merged 3 commits into from
Aug 13, 2021
Merged

[8.x] Update the ParallelRunner to allow for a custom Runner to be resolved #38374

merged 3 commits into from
Aug 13, 2021

Conversation

lukeraymonddowning
Copy link
Contributor

Howdy all!

This PR comes on the back of a new requirement for Collision, in which we want the ability to define the Paratest Runner that should be used under the ParallelRunner.

This allows for the following syntax:

\Illuminate\Testing\ParallelRunner::resolveRunnerUsing(fn($options, $output) => new CustomRunner($options, $output));

When a resolver is defined, the runner will be returned based on the provided resolver logic. When a resolver is not defined, the runner will be returned using the default WrapperRunner currently used.

Thanks for all the hard work and for continuing to maintain the framework.

Kind Regards,
Luke

…olved instead of the default in Collision.
lukeraymonddowning and others added 2 commits August 13, 2021 12:10
Co-authored-by: Nuno Maduro <enunomaduro@gmail.com>
Co-authored-by: Nuno Maduro <enunomaduro@gmail.com>
@driesvints driesvints changed the title [8.x] Updates the ParallelRunner to allow for a custom Runner to be resolved [8.x] Update the ParallelRunner to allow for a custom Runner to be resolved Aug 13, 2021
@taylorotwell taylorotwell merged commit 2d8836d into laravel:8.x Aug 13, 2021
@LastDragon-ru
Copy link
Contributor

How it is supposed to work? I've tried

  1. Calling it in AppServiceProvider
  2. Adding it into bootstrap.php and phpunit.xml
  3. Adding it into bootstrap/app.php

nothing work :(

@lukeraymonddowning lukeraymonddowning deleted the configurable-runner branch April 17, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants