-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Add qualifyColumns method to Model class #38403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
Add qualifyColumns method to Model class
[8.x] Add qualifyColumns method to Model class
Aug 16, 2021
Looks like tests are failing. Please fix these and then mark the PR as ready for review. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
this is my first pull request, I hope all is right.
I would like to suggest to add a qualifyColumns (note the "s") method to the Model class in order to qualify multiple column at once, avoiding to call qualifyColum method multiple times.
I think this may help when we need to qualify multiple columns when using select method of Builder.
$query->select( $userModel->qualifyColumn('name'), $userModel->qualifyColumn('surname'), $userModel->qualifyColumn('address') );
$query->select($userModel->qualifyColumns(['name', 'surname, 'address']));