Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Make getCookie public so it can be directly used in tests #38524

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

mfn
Copy link
Contributor

@mfn mfn commented Aug 24, 2021

Summary

I've a use case for more specific checks on cookies than the current assertCookie provides, i.e. I need the cookie directly.

Since the getCookie contains exactly the boilerplate necessary to get one from the test response, I figured just making it public would make sense.

Thank you 🙏

@taylorotwell taylorotwell merged commit c1e8dc8 into laravel:8.x Aug 24, 2021
@mfn mfn deleted the mp-public-getcookie branch August 26, 2021 10:11
victorvilella pushed a commit to cdsistemas/framework that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants