[9.x] Non-breaking forwardDecoratedCallTo refactor #38908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate version of #38802 that doesn't introduce any potentially breaking changes:
DecoratesQueryBuilderhas just been updated to use the newforwardDecoratedCallTomethod rather than implementing a customforwardCallToQueryBuildermethod.NullDispatcherandMail\Messageis technically a breaking change, which is why this PR for 9.x, but in practice this is fixing unexpected behavior. These changes shouldn't have any impact, and only help prevent accidental bugs.This PR excludes the update to
JsonResource, which was the only place that might have introduced breaking changes in the wild.