Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix #38949 #38962

Merged
merged 2 commits into from
Sep 26, 2021
Merged

[8.x] Fix #38949 #38962

merged 2 commits into from
Sep 26, 2021

Conversation

mateusjunges
Copy link
Contributor

Hi,
This PR should fix #38949. I've added a test which fails without adding the following line

public function passes($attribute, $value)
{
+        $this->messages = [];
...
}

@mateusjunges mateusjunges changed the title wip: Fix #38949 Fix #38949 Sep 26, 2021
@GrahamCampbell GrahamCampbell changed the title Fix #38949 [8.x] Fix #38949 Sep 26, 2021
@GrahamCampbell
Copy link
Member

Is this an issue on 6.x too? If so, please send a PR to that branch instead.

@mateusjunges
Copy link
Contributor Author

@GrahamCampbell i've added this test on ValidatorTest, for 6.x, and it passes without any fix. I think it only happens on 8.x, with the password rule.

@taylorotwell taylorotwell merged commit a0fd30f into laravel:8.x Sep 26, 2021
@mateusjunges mateusjunges deleted the fix#38949 branch September 28, 2021 13:39
victorvilella pushed a commit to cdsistemas/framework that referenced this pull request Oct 12, 2021
* This should fix laravel#38949

* apply ci fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password validation rule fails on valid data if reused
3 participants