Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Fix route groups with no prefix on PHP 8.1 #39115

Merged
merged 2 commits into from
Oct 7, 2021
Merged

[8.x] Fix route groups with no prefix on PHP 8.1 #39115

merged 2 commits into from
Oct 7, 2021

Commits on Oct 6, 2021

  1. PHP 8.1, fix route groups with no prefix. 

    In php 8.1 calling trim() on null values is deprecated and since my route collection have groups without a defined prefix, I get an error on this line of code.
Parsing in an empty string as opposed to null is the minimal change which solves the problem.
    @GuardsmanPanda
    GuardsmanPanda authored Oct 6, 2021
    Configuration menu
    Copy the full SHA
    27b974a View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Added test cast for grouped route without prefix

    @GuardsmanPanda
    GuardsmanPanda committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    b1016a0 View commit details
    Browse the repository at this point in the history