[8.x] Fix code locating Bearer token in InteractsWithInput #39150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
driesvints
approved these changes
Oct 8, 2021
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Oct 9, 2021
…9150) * Fix code locating Bearer token * Update HttpRequestTest.php
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
…9150) * Fix code locating Bearer token * Update HttpRequestTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code currently only looks for the
Bearerstring when locating the Bearer token. However, since the token is base64-encoded, it is possible that the encoded token can also contain the stringBearerwhich actually bit me once in tests.The correct behavior is to look for the string
Bearerwith a trailing space. Spaces cannot be part of the token (see https://datatracker.ietf.org/doc/html/rfc6750#section-2.1).The code already correctly splits the string after 7 characters, assuming that a trailing space is present.
This is a small fix for #38426 which introduced this regression. Before, the code checked the trailing space.