Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add bcmath as an extension suggestion #39360

Merged
merged 1 commit into from
Oct 26, 2021
Merged

[8.x] Add bcmath as an extension suggestion #39360

merged 1 commit into from
Oct 26, 2021

Conversation

timacdonald
Copy link
Member

The multiple_of validation rule requires bcmath. Added as a suggestion in 8.x but it might be good to make a hard requirement in 9.x for a smoother transition?

I can add a note to the docs as well indicating that this ext is needed if you wanna merge this one.

@driesvints
Copy link
Member

Good idea to add it to suggest but I wouldn't add a hard dependency to require in 9.x if it's only for one validation rule.

Can you also add the suggest in the composer.json of the validation component?

It's indeed a good idea to also PR to the docs of this validation rule that this extension is required 👍

@taylorotwell taylorotwell merged commit 99e392b into laravel:8.x Oct 26, 2021
@driesvints
Copy link
Member

I added the extra suggest here: b53152b

@timacdonald
Copy link
Member Author

Sounds good to me Dries. Just sent up the docs PR for ya.

@driesvints
Copy link
Member

@timacdonald thanks man :)

@GrahamCampbell GrahamCampbell changed the title [8.x] add bcmath as an extension suggestion [8.x] Add bcmath as an extension suggestion Oct 26, 2021
@timacdonald
Copy link
Member Author

Me right now...

work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants