Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix: prevent re-casting of enum values #39597

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

tomschlick
Copy link
Contributor

I ran into an issue in testing 8.1 enums where when using observers/jobs to set an enum after a previous update it was trying to re-cast the enum value into the enum class using EnumClass::from() which only accepts an integer/string value. A simple check here stops that from happening.

@taylorotwell taylorotwell merged commit 34e63fe into laravel:8.x Nov 15, 2021
@taylorotwell
Copy link
Member

Thanks for contributing to Laravel! ❤️

@tomschlick tomschlick deleted the patch-2 branch November 18, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants