[8.x] Fixes reporting deprecations when logger is not ready yet #39938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorotwell
deleted the
fix/fixes-reporting-deprecations-when-logger-not-ready
branch
|
Unfortunately the issue isn't really fixed. Will leave a comment there tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #286, and laracasts.com/discuss/channels/laravel/logmanager-not-found, by not trying to log deprecations if the deprecation itself comes while composer is trying to load the
LogManagerclass.It's unclear, at this time, where the deprecation comes from, but we suspect that it's from one of the
LogManagerclass dependencies at one specific version that is allowed by our composer.json file.