Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Automatically add event description when scheduling a command #40286

Merged
merged 1 commit into from
Jan 7, 2022
Merged

[8.x] Automatically add event description when scheduling a command #40286

merged 1 commit into from
Jan 7, 2022

Conversation

maartenpaauw
Copy link
Contributor

Description

This code will use the command description as event description. This could be useful when listing all scheduled commands.

Before

$schedule->command(Command::class)
    ->description((new Command())->getDescription())
    ->daily();

After

$schedule->command(Command::class)
    ->daily();

The code above will output the same result when running php artisan schedule:list.

@taylorotwell taylorotwell merged commit 0fb801a into laravel:8.x Jan 7, 2022
@taylorotwell
Copy link
Member

Thanks for contributing to Laravel! ❤️

@GrahamCampbell GrahamCampbell changed the title Automatically add event description when scheduling a command [8.x] Automatically add event description when scheduling a command Jan 7, 2022
@maartenpaauw maartenpaauw deleted the feature/automatically-add-event-description-when-scheduling-a-command branch January 7, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants