[9.x] Throw invalid argument exception from cache helper #40287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the exception thrown by
cache()
to be an\InvalidArgumentException
. Not only does this make more sense than the base\Exception
class, editors such as PHPStorm will not complain about uncaught logic exceptions while they will complain about uncaught base exceptions.This change should be non breaking, as any matching catch expression would still match.