[8.x] Add multibyte support to string padding helper functions #41899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multibyte strings to the
Str::padBoth
,Str::padLeft
, andStr::padRight
helper functions.This is especially useful for localized strings, where accented characters or other multibyte glyphs were incorrectly padded before.
PHP has yet to implement a native
mb_str_pad
function so this PR adds aStr::mbStrPad
helper function adapted from a comment on the PHP docs. There is an ongoing 19 year-old PHP request for this native function, but as it is yet to see any progress, it seems appropriate to implement a workaround in the framework.