Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Adjust forever time for cookies #43806

Merged
merged 2 commits into from
Aug 22, 2022
Merged

[9.x] Adjust forever time for cookies #43806

merged 2 commits into from
Aug 22, 2022

Conversation

driesvints
Copy link
Member

The maximum amount of days for an Expiration date of a cookie is apparently limited to 400 days.

See https://httpwg.org/http-extensions/draft-ietf-httpbis-rfc6265bis.html#section-4.1.2.1

Also #43804

@Tofandel
Copy link
Contributor

Just changing a comment is not enough to change the value 😅

2628000 needs to be changed to 576000 (in forget as well I guess)

@driesvints
Copy link
Member Author

Done thanks. I left the forgot value for BC reasons if there are some browsers that still have set cookies with 5 years expiry.

@taylorotwell taylorotwell merged commit 8c77d8c into 9.x Aug 22, 2022
@taylorotwell taylorotwell deleted the driesvints-patch-1 branch August 22, 2022 13:22
bogdankharchenko added a commit to bogdankharchenko/framework that referenced this pull request Sep 6, 2022
@bogdankharchenko
[8.x] Align Remember Me Cookie Duration with CookieJar expiration
9ec63b6 
This PR laravel#43806 changed the max cookie lifetime of the "forever" cookie - these two values are now misaligned.
@bogdankharchenko bogdankharchenko mentioned this pull request Sep 6, 2022
Merged
taylorotwell pushed a commit that referenced this pull request Sep 6, 2022
@bogdankharchenko
[9.x] Align Remember Me Cookie Duration with CookieJar expiration (#4…
43622bd 
…4026)

* [8.x] Align Remember Me Cookie Duration with CookieJar expiration

This PR #43806 changed the max cookie lifetime of the "forever" cookie - these two values are now misaligned.

* Update Test
taylorotwell pushed a commit to illuminate/auth that referenced this pull request Sep 6, 2022
@bogdankharchenko
[9.x] Align Remember Me Cookie Duration with CookieJar expiration (#4…
4a46b32 
…4026)

* [8.x] Align Remember Me Cookie Duration with CookieJar expiration

This PR laravel/framework#43806 changed the max cookie lifetime of the "forever" cookie - these two values are now misaligned.

* Update Test
@drbyte drbyte mentioned this pull request Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driesvints @Tofandel @taylorotwell