[9.x] Update dd function when running on virtualized dev environments

[jevouslue]

This PR enhances the recently added feature, dd function output (#44211).
The great feature "clickable file path" doesn't work when running on virtualized dev environments, including Laravel Sail.

You just add the app.editor_project_path configuration, and the source link will work properly even on your virtualized dev environments.

config/app.php

<?php

use Illuminate\Support\Facades\Facade;

return [
    'editor' => env('EDITOR'),  // UPDATE
    'editor_project_path' => env('EDITOR_PROJECT_PATH'),  // ADD!

    // the other settings
];

Of course, this is optional.

And I also think the params should be in the .env file.
.env(example)

EDITOR=phpstorm
EDITOR_PROJECT_PATH=/Users/username/Desktop/example-app

This is my first PR for any OSS projects, maybe something weird...

[nunomaduro]

There is no way to infer the project's path, so the user don't have to hardcode it on his configuration file / environment variables?

[fabio-ivona]

I don't think you can get the host path from inside a docker container. Also, this feature would be useful for opening local files from a dd() on a remote server

Maybe it could be useful to use a single env value for both ingnition and dd() features (for ignition is currently used IGNITION_LOCAL_SITES_PATH)

[jevouslue]

Yes, there is no way to automatically infer the project's path as the editor that the users use.
That's why I have the user hardcode it.

Unfortunately, I have no idea.
Do you have any solution?

[jevouslue]

@fabio-ivona
It sounds good!
IGNITION_EDITOR and IGNITION_LOCAL_SITES_PATH is suitable for them.

[fabio-ivona]

I would use a more general key, like (EDITOR_BASE_PATH) and ask to Spatie to support that one as well

using "IGNITION" for this feature doesn't seem consistent to me

[sirmathays]

I made a pull request (#44378) that seems to overlap with this one at least a little bit:

// config/app.php

return [
    // ....
    'editor' => 'vscode',
    'editor_href' => 'vscode-remote/wsl+Ubuntu-20.04{file}:{line}'
    // ...
];

Then in HtmlDumper the {file} and {line} gets replaced with the actual values. This approach will make the url work with VSCode and WSL.

[nunomaduro]

Closing this pull request, as I will be working on this format: #44378 (comment).

[nunomaduro]

@jevouslue Do you mind of try to use the branch #44406 locally, and let me know if it works for you in both the terminal and browser please.

[jevouslue]

@nunomaduro
For me, the following configuration worked on my Docker via Laravel Sail 👍

'editor' => [
    'name' => 'phpstorm',
    'base_path' => '/Users/username/Desktop/example-app',
],

let me know if it works for you in both the terminal and browser please.

In the terminal, it just displays the file path as before, and it's non-clickable, right? (I mean the color)
then it works well!

FYI It seems different when I enable the editor setting.

You're always doing great!
Thank you so much!
I can't wait for it to be merged.

[fabio-ivona]

@jevouslue isn't the second one clickable?

which terminal are you using?

[jevouslue]

@fabio-ivona
Sorry, I just misunderstood.
(I forget to press a control key...)

The second one is also clickable!