Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Recompiles views when necessary #44737

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

nunomaduro
Copy link
Member

This pull request fixes an issue that may happen when deploying Laravel applications after #44487. If the compiled views directory gets deleted via the view:clear command, while a worker is running, the worker does not handle correctly the fact that the compiled views may be missing.

php artisan view:clear
sleep 5 // If an queue job, that uses views, tries to re-send a job, it may face `File does not exist at path`...
php artisan queue:restart

To address this issue, we simply re-compile the given view if necessary.

@nunomaduro nunomaduro marked this pull request as ready for review October 26, 2022 12:24
@taylorotwell taylorotwell merged commit c06913f into 9.x Oct 26, 2022
@taylorotwell taylorotwell deleted the fix/recompile-views-if-necessary branch October 26, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants