Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #45582
Since the
Builder\Query
flattens the binding array before applying it a method likewhereIn
can accept an associative array as its second argument (as demonstrated in the added tests).So to make
whereIntegerInRaw
compatible withwhereIn
we need to flatten the values before casting it to int.@staudenmeir
whereIn
method tries to avoid accepting nested arrays as$values
with the check below, but it is not enough and can be bypassed with an input like this:and due to the above flattening, it will continue to work as if it was called like this: