Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fix recorderHandler not recording changes made by middleware #47614

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

j3j5
Copy link
Contributor

@j3j5 j3j5 commented Jun 29, 2023

It fixes #47613.

Related: #40636

@j3j5
Copy link
Contributor Author

j3j5 commented Jun 29, 2023

The failing tests do not seem to be related.

1) Illuminate\Tests\Integration\Cache\DynamoDbStoreTest::testItemsCanBeStoredAndRetrieved
Aws\DynamoDb\Exception\DynamoDbException: Error executing "DescribeTable" on "http://localhost:8888"; AWS HTTP error: Client error: `POST http://localhost:8888` resulted in a `400 Bad Request` response:
{"__type":"com.amazonaws.dynamodb.v20120810#UnrecognizedClientException","Message":"The Access Key ID or security token  (truncated...)
 UnrecognizedClientException (client): The Access Key ID or security token is invalid. - {"__type":"com.amazonaws.dynamodb.v20120810#UnrecognizedClientException","Message":"The Access Key ID or security token is invalid."}

@j3j5 j3j5 changed the title Fix recorderHandler not recording changes made by middleware [10.x] Fix recorderHandler not recording changes made by middleware Jun 29, 2023
@taylorotwell taylorotwell merged commit f03e652 into laravel:10.x Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpAssertSent fails when using withMiddleware() with a middleware that modifies the request
2 participants