Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Move class from file logic in Console Kernel to dedicated method #47665

Merged
merged 2 commits into from
Jul 8, 2023
Merged

[10.x] Move class from file logic in Console Kernel to dedicated method #47665

merged 2 commits into from
Jul 8, 2023

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Jul 5, 2023

Hello!

I still am unable to auto-register my commands (see #47312), moving the Console Kernel "class from file" logic to its own method will allow me (and others) to override the specific logic without having to duplicate most of the load method.

Thanks!

@taylorotwell taylorotwell merged commit 33aa4a9 into laravel:10.x Jul 8, 2023
@calebdw
Copy link
Contributor Author

calebdw commented Jul 8, 2023

Thank you sir!

@calebdw calebdw deleted the kernel_class_from_file branch June 13, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebdw @taylorotwell