[11.x] Add --without-reverb and --without-node arguments to install:broadcasting command
#50662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
deleted the
add-arguments-for-installing-broadcasting-without-reverb-or-npm-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two additional arguments to the
install:broadcastingcommand.They allow developers to skip the "Install Reverb" and "Install Node dependencies" prompts when scaffolding the rest of the broadcasting stuff.
Use Case
We have an optional "Collaboration" feature in our package. During the setup command, we give developers the option of which broadcasting connection they wish to use (eg. Reverb / Pusher / etc).
However, since we run
install:broadcastingduring the setup command, it'll install Reverb even if the developer picked to use Pusher or another driver.It's a similar-ish situation with the Node dependencies. Since our package bundles with Laravel Echo, our developers don't need the
echo.jsfile (& it's dependencies) added to their project.