-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x] Fixed incorrect assumption in QueriesRelationships
that the owner key is necessarily the model key
#50706
[10.x] Fixed incorrect assumption in QueriesRelationships
that the owner key is necessarily the model key
#50706
Conversation
…ey is necessarily the model key
QueriesRelationships
that the owner k…QueriesRelationships
that the owner key is necessarily the model key
cc @tobyzerner |
Ok, I'm not sure why the tests are failing here. |
Good catch @GrahamCampbell! Not sure why the tests are failing either, strange 🤔 |
|
Thanks. My 10:30PM brain didn't even think to check that the method was not public. 😆 |
Probably need a test for this. |
@GrahamCampbell feel free to resend this with a test, thanks. |
Fixes a bug introduced earlier (#38668) that nobody noticed because:
whereMorphedTo
is a pretty rare use case. I've never used it before, and neither does any of the first party library code that I have locally.