Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuntimeException message when no data has been found #51133

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

mikemeijer
Copy link
Contributor

I discovered an inconsistency in the getData method of the Illuminate\Notifications\Channels\BroadcastChannel.
When both the toBroadcast and toArray doesn't exists it only shows the Notification is missing toArray method. while it shows Notification is missing toDatabase / toArray method. in the getData of the Illuminate\Notifications\Channels\DatabaseChannel.

I've update this line to be more consistent in the exception message of both classes.

@taylorotwell taylorotwell merged commit 5e209bc into laravel:11.x Apr 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants