[11.x] Replace all backed enums with values when building URLs #51524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a URL, the
UrlGenerator
takes each parameter that is a backed enum instance, and replaces it with its underlying value. This PR lets the UrlGenerator also replace backed enums that are nested more deeply in the$parameters
array. This is useful when passing an array of enums as one of the parameters, for example when adding a filter query parameter.Example:
Previous behavior:
You'd get this URL from the above command, which includes the name and value of each enum instance separately:
In order to get the shorter URL you'd have to add
->value
to each enum instance.Breaking changes
None as far as I can tell, unless you were using arrays of enum instances as parameter values as in the above example. I don't assume anyone did, looking at the format of the above URL, but maybe I'm missing something.