[11.x] Add get, write and forget cache events
#51560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kinda worried about performance degradation here, not a fan of this. |
|
With #51032 (already release) you would be able to opt-out of these! Not sure if it makes sense to make even more granular than that. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow tracing how long read/write cache operations take I've added events that fire before the already existing events that fired after calling the cache store. This makes it so that every cache operation has a "start" and "end" event that allows tracking the time between them.
To make sure every cache operation has a matching start and end event there are also 2 new failed events. The
$resultcould also be added to the current events but not sure if it's a BC change to do that so instead I opted for the new failed events.