Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Avoid using Laravel new error page if app.debug changes to true at runtime #51705

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Jun 4, 2024

Laravel only register Renderer instance when the application is booted with app.debug as true. This would cause an error (mainly during development) if the configuration were changed to true before an exception occurred.

at runtime

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone changed the title [11.x] Avoid using Laravel new renderer if app.debug changes to true at runtime [11.x] Avoid using Laravel new error page if app.debug changes to true at runtime Jun 4, 2024
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review June 4, 2024 07:49
@taylorotwell taylorotwell merged commit 6adf982 into 11.x Jun 4, 2024
29 checks passed
@taylorotwell taylorotwell deleted the mismatch-debug branch June 4, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants