[11.x] Fix PasswordBroker constructor docblock #52023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
approved these changes
Jul 5, 2024
marius-mcp
reviewed
Jul 5, 2024
| @@ -39,7 +39,7 @@ class PasswordBroker implements PasswordBrokerContract | |||
| * | |||
| * @param \Illuminate\Auth\Passwords\TokenRepositoryInterface $tokens | |||
| * @param \Illuminate\Contracts\Auth\UserProvider $users | |||
| * @param \Illuminate\Contracts\Events\Dispatcher $users | |||
| * @param \Illuminate\Contracts\Events\Dispatcher|null $dispatcher | |||
There was a problem hiding this comment.
Dockblocks for type-hinted properties in function definitions are useless. (unless they bring new info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third parameter of
PasswordBrokerconstructor is$dispatcher(an instance of\Illuminate\Contracts\Events\Dispatcher) but it's currently documented as$users. It might be accidentally copied in the past.