Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Declare bindings and singletons properties in Service Provider #52256

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

Anton5360
Copy link
Contributor

@Anton5360 Anton5360 commented Jul 25, 2024

This PR basically repeats this one. I want to give it a second chance, maybe finally 5 years later its time has come :)

Just from developer perspective - I'm pretty tired to go every time to the documentation and check the name for these "magick" variables as I'm not able to see them in the source code + I found not many people even knowing about this small feature.

It does not hurt a performance in any way - perhaps it might have hurt legacy php versions, but definitely not a php 8.x

@driesvints
Copy link
Member

driesvints commented Jul 26, 2024

Reverting this one because it seems to break things for people. #52286

@daniser
Copy link
Contributor

daniser commented Jul 26, 2024

@driesvints Maybe merge this into 12.x branch?

@driesvints
Copy link
Member

I don't think we'll reconsider this one sorry.

@Anton5360
Copy link
Contributor Author

Anton5360 commented Jul 26, 2024

@driesvints Is that a final decision or still might be worthy to recreate the PR for version 12 ?
I assume such issue case is more an exception than a common practice, so again I assume it`s not a breaking change for the most of projects/libraries

@rodrigopedra
Copy link
Contributor

You can send a PR to add these annotations to the base ServiceProvider class to have your IDE behave as expected:

/**
 * @property array $singletons = []
 * @property array $bindings = []
 */
abstract class ServiceProvider

Maybe the maintainers would be open to that

@devajmeireles
Copy link
Contributor

You can send a PR to add these annotations to the base ServiceProvider class to have your IDE behave as expected:

/**
 * @property array $singletons = []
 * @property array $bindings = []
 */
abstract class ServiceProvider

Maybe the maintainers would be open to that

Sure thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants