Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Add php doc for ServiceProvider bindings and singletons properties #52298

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[11.x] Add php doc for ServiceProvider bindings and singletons properties #52298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d2b366
Add php doc for bindings and singletons magick properties
Anton5360 Jul 28, 2024
b8c825f
Add description
Anton5360 Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Illuminate/Support/ServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
use Illuminate\Database\Eloquent\Factory as ModelFactory;
use Illuminate\View\Compilers\BladeCompiler;

/**
* @property array<class-string, class-string> $bindings All of the container bindings that should be registered.
* @property array<class-string, class-string> $singletons All of the singletons that should be registered.
Comment on lines +14 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types are wrong, because bindings (and singletons) don't need to be class strings. They should be typehinted as string instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest singletons' key to be array-key type, since integer is allowed:

framework/src/Illuminate/Foundation/Application.php

Lines 880 to 884 in c2eb318

foreach ($provider->singletons as $key => $value) {
$key = is_int($key) ? $value : $key;
$this->singleton($key, $value);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to send in follow up PR's 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#52308

*/
abstract class ServiceProvider
{
/**
Expand Down